NIFI-12785 Refactored InvokeHttp code to avoid double encoding of the entered URL.#8458
Closed
dan-s1 wants to merge 3 commits intoapache:mainfrom
Closed
NIFI-12785 Refactored InvokeHttp code to avoid double encoding of the entered URL.#8458dan-s1 wants to merge 3 commits intoapache:mainfrom
dan-s1 wants to merge 3 commits intoapache:mainfrom
Conversation
10 tasks
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for working on this @dan-s1. I have one question on implementation to make sure I am following the changes.
...e/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
Show resolved
Hide resolved
Contributor
Author
|
@exceptionfactory Can you please look at this PR when you get a chance? Our team is also having the issue detailed in this ticket and we would like to see this fix for this. Thank you! |
exceptionfactory
approved these changes
Mar 8, 2024
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for adding the test @dan-s1, that definitely clarifies and confirms the expected behavior! +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to solve the problem of the issue reported regarding URLs being double encoded. The refactor for this PR entailed keeping the fix for NIFI-12513 intact for validation but for actual use, the url is used in InvokeHttp as it was entered by the user. #8459 is the backport of this fix to v1.
Summary
NIFI-12785
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation