Skip to content

NIFI-12785 Refactored InvokeHttp code to avoid double encoding of the entered URL.#8458

Closed
dan-s1 wants to merge 3 commits intoapache:mainfrom
dan-s1:NIFI-12785
Closed

NIFI-12785 Refactored InvokeHttp code to avoid double encoding of the entered URL.#8458
dan-s1 wants to merge 3 commits intoapache:mainfrom
dan-s1:NIFI-12785

Conversation

@dan-s1
Copy link
Copy Markdown
Contributor

@dan-s1 dan-s1 commented Feb 28, 2024

This PR aims to solve the problem of the issue reported regarding URLs being double encoded. The refactor for this PR entailed keeping the fix for NIFI-12513 intact for validation but for actual use, the url is used in InvokeHttp as it was entered by the user. #8459 is the backport of this fix to v1.

Summary

NIFI-12785

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@dan-s1 dan-s1 changed the title NIFI-12785 Refactored the code to avoid double encoding. NIFI-12785 Refactored InvokeHttp code to avoid double encoding. Mar 1, 2024
@dan-s1 dan-s1 changed the title NIFI-12785 Refactored InvokeHttp code to avoid double encoding. NIFI-12785 Refactored InvokeHttp code to avoid double encoding of the entered URL. Mar 4, 2024
Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this @dan-s1. I have one question on implementation to make sure I am following the changes.

@dan-s1
Copy link
Copy Markdown
Contributor Author

dan-s1 commented Mar 8, 2024

@exceptionfactory Can you please look at this PR when you get a chance? Our team is also having the issue detailed in this ticket and we would like to see this fix for this. Thank you!

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the test @dan-s1, that definitely clarifies and confirms the expected behavior! +1 merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants