Skip to content

NIFI-12857 Add test for and refactor implementation of QueuePrioritizer#8466

Closed
EndzeitBegins wants to merge 1 commit intoapache:mainfrom
EndzeitBegins:NIFI-12857
Closed

NIFI-12857 Add test for and refactor implementation of QueuePrioritizer#8466
EndzeitBegins wants to merge 1 commit intoapache:mainfrom
EndzeitBegins:NIFI-12857

Conversation

@EndzeitBegins
Copy link
Contributor

@EndzeitBegins EndzeitBegins commented Mar 1, 2024

Summary

Adds test for and refactors implementation of QueuePrioritizer.

NIFI-12857

Additionally, removed some dead code from TestStandardFlowFileQueue.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@EndzeitBegins EndzeitBegins marked this pull request as draft March 3, 2024 18:02
@EndzeitBegins EndzeitBegins marked this pull request as ready for review March 7, 2024 15:35
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EndzeitBegins can you rebase this PR from the current main branch? It includes some improvements for the build process that should address the last failure in the Static Analysis workflow step.

@EndzeitBegins EndzeitBegins marked this pull request as draft March 26, 2024 15:09
@EndzeitBegins EndzeitBegins marked this pull request as ready for review March 26, 2024 16:57
@EndzeitBegins
Copy link
Contributor Author

Of course, just rebased on the last commit of main.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EndzeitBegins Returning to this PR, I noticed a couple stylistic adjustments needed, but with those and one more rebase, this looks close to completion.

@EndzeitBegins
Copy link
Contributor Author

EndzeitBegins commented May 9, 2024

Thank you for the review @exceptionfactory.

I've just rebased the PR on the latest commit on main, added the missing line break to the test, and added braces to conditional blocks where they were missing.

I would appreciate another look.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @EndzeitBegins! +1 merging

@EndzeitBegins EndzeitBegins deleted the NIFI-12857 branch May 9, 2024 20:55
shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
This closes apache#8466

Signed-off-by: David Handermann <exceptionfactory@apache.org>
shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
This closes apache#8466

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants