NIFI-12857 Add test for and refactor implementation of QueuePrioritizer#8466
NIFI-12857 Add test for and refactor implementation of QueuePrioritizer#8466EndzeitBegins wants to merge 1 commit intoapache:mainfrom
Conversation
1c1b6b6 to
75b3e5a
Compare
exceptionfactory
left a comment
There was a problem hiding this comment.
@EndzeitBegins can you rebase this PR from the current main branch? It includes some improvements for the build process that should address the last failure in the Static Analysis workflow step.
4f71561 to
c9e49e0
Compare
|
Of course, just rebased on the last commit of |
exceptionfactory
left a comment
There was a problem hiding this comment.
@EndzeitBegins Returning to this PR, I noticed a couple stylistic adjustments needed, but with those and one more rebase, this looks close to completion.
...ork/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/QueuePrioritizer.java
Outdated
Show resolved
Hide resolved
...ork/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/QueuePrioritizer.java
Outdated
Show resolved
Hide resolved
...ork/nifi-framework-core/src/main/java/org/apache/nifi/controller/queue/QueuePrioritizer.java
Outdated
Show resolved
Hide resolved
...nifi-framework-core/src/test/java/org/apache/nifi/controller/queue/QueuePrioritizerTest.java
Outdated
Show resolved
Hide resolved
|
Thank you for the review @exceptionfactory. I've just rebased the PR on the latest commit on I would appreciate another look. |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks @EndzeitBegins! +1 merging
This closes apache#8466 Signed-off-by: David Handermann <exceptionfactory@apache.org>
This closes apache#8466 Signed-off-by: David Handermann <exceptionfactory@apache.org>
Summary
Adds test for and refactors implementation of
QueuePrioritizer.NIFI-12857
Additionally, removed some dead code from
TestStandardFlowFileQueue.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation