Skip to content

NIFI-12864 Corrected the NOTICE file to refer to the correct file which uses Spring's UriComponentsBuilder.#8470

Closed
dan-s1 wants to merge 1 commit intoapache:mainfrom
dan-s1:NIFI-12864
Closed

NIFI-12864 Corrected the NOTICE file to refer to the correct file which uses Spring's UriComponentsBuilder.#8470
dan-s1 wants to merge 1 commit intoapache:mainfrom
dan-s1:NIFI-12864

Conversation

@dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Mar 4, 2024

Summary

NIFI-12864

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@dan-s1
Copy link
Contributor Author

dan-s1 commented Mar 4, 2024

@exceptionfactory Can ci-workflow / Ubuntu Corretto JDK 21 EN (pull_request) be restarted? The failure has nothing to do with my change as my change was only on the NOTICE file and not on any code. Thanks!

@exceptionfactory
Copy link
Contributor

@exceptionfactory Can ci-workflow / Ubuntu Corretto JDK 21 EN (pull_request) be restarted? The failure has nothing to do with my change as my change was only on the NOTICE file and not on any code. Thanks!

@dan-s1 You should be able to restart GitHub Actions after linking your Apache account to your GitHub account, I can provide additional details if needed. In this case, however, it is less necessary, since this is a documentation change, and the other workflows completed.

@dan-s1
Copy link
Contributor Author

dan-s1 commented Mar 4, 2024

@exceptionfactory I thought I had linked my Apache and Github accounts yet I do not see an option for restarting on my own PRs while I do see it for PRs of others. Please let me know what I else I need to do. Thanks!

@exceptionfactory
Copy link
Contributor

@dan-s1 The restart job option is available from the jobs view:

https://github.com/apache/nifi/actions/runs/8145366866/job/22261448058?pr=8470

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dan-s1, proceeding to merge +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants