[NIFI-12922] semantic dialog size configurations#8535
Merged
mcgilman merged 27 commits intoapache:mainfrom Mar 29, 2024
Merged
Conversation
Contributor
|
Will review... |
scottyaslan
force-pushed
the
NIFI-12922
branch
2 times, most recently
from
84a94c6 to
5253b6f
Compare
mcgilman
reviewed
Mar 25, 2024
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks for the PR @scottyaslan! I've left a few notes for somethings I've noticed while running with it.
...common/controller-service/enable-controller-service/enable-controller-service.component.html
Outdated
Show resolved
Hide resolved
...-web-frontend/src/main/nifi/src/app/ui/common/component-state/component-state.component.scss
Show resolved
Hide resolved
...rameter-contexts/ui/parameter-context-listing/parameter-table/parameter-table.component.html
Outdated
Show resolved
Hide resolved
...nifi-web-frontend/src/main/nifi/src/app/ui/common/yes-no-dialog/yes-no-dialog.component.html
Show resolved
Hide resolved
...story/state/flow-configuration-history-listing/flow-configuration-history-listing.effects.ts
Outdated
Show resolved
Hide resolved
...end/src/main/nifi/src/app/pages/access-policies/state/access-policy/access-policy.effects.ts
Outdated
Show resolved
Hide resolved
.../nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/tsconfig.json
Outdated
Show resolved
Hide resolved
...ifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_listing-table.scss
Show resolved
Hide resolved
scottyaslan
force-pushed
the
NIFI-12922
branch
3 times, most recently
from
46834e4 to
501b7c2
Compare
mcgilman
reviewed
Mar 27, 2024
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks for the updates @scottyaslan! I've left a few more notes below.
...ion-history/ui/flow-configuration-history-listing/purge-history/purge-history.component.html
Show resolved
Hide resolved
...in/nifi/src/app/pages/flow-designer/state/controller-services/controller-services.effects.ts
Show resolved
Hide resolved
...i-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/state/flow/flow.effects.ts
Outdated
Show resolved
Hide resolved
scottyaslan
force-pushed
the
NIFI-12922
branch
2 times, most recently
from
592ebdf to
9b05d09
Compare
mcgilman
reviewed
Mar 29, 2024
...as/items/processor/edit-processor/relationship-settings/relationship-settings.component.html
Outdated
Show resolved
Hide resolved
mcgilman
approved these changes
Mar 29, 2024
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks for the updates @scottyaslan! Looks good. Will merge once CI completes.
… screen for smaller screen heights
…om the override policy dialog
…e any size but should override the maxWidth: 24rem, Cancel Dialog have no size
…tting edit processor layouts, add border and overflow scrolling for referencing component listings UX everywhere
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIFI-12922