Skip to content

NIFI-2566: Refactoring to improve robustness of cluster#866

Closed
markap14 wants to merge 4 commits intoapache:masterfrom
markap14:NIFI-2566
Closed

NIFI-2566: Refactoring to improve robustness of cluster#866
markap14 wants to merge 4 commits intoapache:masterfrom
markap14:NIFI-2566

Conversation

@markap14
Copy link
Copy Markdown
Contributor

No description provided.

… responsible for determining who is the Cluster Coordinator
…onnectionStatus; use LeaderElectionManager to determine roles instead

final boolean updated = clusterCoordinator.resetNodeStatus(updatedStatus, updateId == null ? -1L : updateId);
if (updated) {
// TODO - REMOVE THE ASTERISKS
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lingering Todo, can it be removed?

…luster topology, cluster coordinator will provide updated information back to the nodes
@JPercivall
Copy link
Copy Markdown
Contributor

@markap14, I'm having trouble running a standalone instance with this PR. I get the at I can't start the FlowController due to (very long message, took the end):

Caused by: java.lang.IllegalStateException: The 'nifi.zookeeper.connect.string' property is not set in nifi.properties at org.apache.nifi.controller.cluster.ZooKeeperClientConfig.createConfig(ZooKeeperClientConfig.java:76) ~[nifi-framework-core-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT] at org.apache.nifi.controller.leader.election.CuratorLeaderElectionManager.<init>(CuratorLeaderElectionManager.java:61) ~[nifi-framework-core-1.0.0-SNAPSHOT.jar:1.0.0-SNAPSHOT] at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) ~[na:1.8.0_74] at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) ~[na:1.8.0_74] at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) ~[na:1.8.0_74] at java.lang.reflect.Constructor.newInstance(Constructor.java:423) ~[na:1.8.0_74] at org.springframework.beans.BeanUtils.instantiateClass(BeanUtils.java:147) ~[spring-beans-4.2.4.RELEASE.jar:4.2.4.RELEASE] ... 52 common frames omitted

@markap14
Copy link
Copy Markdown
Contributor Author

@JPercivall I pushed an update that should address this issue.

…ng by creating a standalone-instance version of the Leader Election Manager. Also added Controller Service enabled/disabled state to fingerprint rather than attempting to update the state when joining the cluster, as the implementation was incorrect and the correct implementation will be a rather significant effort that doesn't have to happen for 1.0.0 release
@JPercivall
Copy link
Copy Markdown
Contributor

JPercivall commented Aug 17, 2016

+1

Visually verified code, and did a contrib check build rebased to master. In a 3 node secure cluster did all sorts of tests involving connecting, disconnecting, restarting, and starting/stopping components. All behaved as expected. Thanks @markap14, I will merge it in.

Edit: Also started up a standealone instance to verify things didn't get messed up there.

@asfgit asfgit closed this in e42ea9a Aug 17, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants