NIFI-13084 Backport Allow disabling scientific notation when writing …#8686
Conversation
| } else { | ||
| serializedString = (String) serialized; | ||
| } | ||
|
|
There was a problem hiding this comment.
I feel it's risky to remove the check for pretty formatting form the backport. A later backport of https://issues.apache.org/jira/browse/NIFI-12480 is not straightforward, it's very possible this wouldn't be added back. I see no drawback in leaving it here.
| final boolean serializedPretty = serializedString.contains("\n"); | |
| if (serializedPretty != this.prettyPrint) { | |
| return false; | |
| } |
There was a problem hiding this comment.
@tpalfy Thank you for the comment, I agree, we need to avoid possible merge issues.
I think it would be the best if I backported NIFI-12480 first and when it is merged to support/nifi-1.x, we can continue with the actual ticket.
I created another ticket for backporting NIFI-12480, will create the PR for it soon: https://issues.apache.org/jira/browse/NIFI-13090
…JSON (NIFI-12697) Co-authored-by: krisztina-zsihovszki <zsikrisz@gmail.com>
9b5a1be to
e8d1496
Compare
|
LGTM |
Summary
NIFI-13084
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
support/nifi-1.xbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation