Skip to content

NIFI-13084 Backport Allow disabling scientific notation when writing …#8686

Merged
asfgit merged 1 commit intoapache:support/nifi-1.xfrom
krisztina-zsihovszki:NIFI-13084
Apr 24, 2024
Merged

NIFI-13084 Backport Allow disabling scientific notation when writing …#8686
asfgit merged 1 commit intoapache:support/nifi-1.xfrom
krisztina-zsihovszki:NIFI-13084

Conversation

@krisztina-zsihovszki
Copy link
Copy Markdown
Contributor

Summary

NIFI-13084

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the support/nifi-1.x branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • [x ] JDK 8

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@turcsanyip turcsanyip requested a review from tpalfy April 22, 2024 19:30
} else {
serializedString = (String) serialized;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel it's risky to remove the check for pretty formatting form the backport. A later backport of https://issues.apache.org/jira/browse/NIFI-12480 is not straightforward, it's very possible this wouldn't be added back. I see no drawback in leaving it here.

Suggested change
final boolean serializedPretty = serializedString.contains("\n");
if (serializedPretty != this.prettyPrint) {
return false;
}

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tpalfy Thank you for the comment, I agree, we need to avoid possible merge issues.
I think it would be the best if I backported NIFI-12480 first and when it is merged to support/nifi-1.x, we can continue with the actual ticket.
I created another ticket for backporting NIFI-12480, will create the PR for it soon: https://issues.apache.org/jira/browse/NIFI-13090

…JSON (NIFI-12697)

Co-authored-by: krisztina-zsihovszki <zsikrisz@gmail.com>
@asfgit asfgit merged commit e8d1496 into apache:support/nifi-1.x Apr 24, 2024
@tpalfy
Copy link
Copy Markdown
Contributor

tpalfy commented Apr 24, 2024

LGTM
Thank you for you work @krisztina-zsihovszki !
Merged into support/nifi-1.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants