[NIFI-13095] surface and contrast improvements#8707
Merged
rfellows merged 18 commits intoapache:mainfrom Apr 30, 2024
Merged
Conversation
scottyaslan
force-pushed
the
NIFI-13095
branch
2 times, most recently
from
06d50e0 to
f36f86a
Compare
Contributor
|
reviewing... |
rfellows
requested changes
Apr 29, 2024
Contributor
rfellows
left a comment
rfellows
left a comment
There was a problem hiding this comment.
Found a few things that should get cleaned up.
...d/src/main/nifi/src/app/pages/flow-designer/service/manager/process-group-manager.service.ts
Show resolved
Hide resolved
...ntend/src/main/nifi/src/app/pages/flow-designer/service/manager/processor-manager.service.ts
Show resolved
Hide resolved
...ain/nifi/src/app/pages/flow-designer/service/manager/remote-process-group-manager.service.ts
Show resolved
Hide resolved
...ifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_listing-table.scss
Outdated
Show resolved
Hide resolved
...ages/flow-designer/ui/canvas/graph-controls/operation-control/operation-control.component.ts
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@rfellows thanks for the feedback. I have addressed your comments. Let me know if you find anything else. |
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
* [NIFI-13095] surface and contrast improvements * [NIFI-12833] primary node icon light/dark mode styling * [NIFI-13101] error page background color now matches light/dark theme * update PG and RPG names to use the material palette contrast color * update listing header text to use the material palette contrast color * update draggable icon hover styles * use surface contrast color for banners * use nifi-surface-default * update to use material primary contrast color for text displayed on top of material surfaces * restore context menu border * restore material theme * fix selected listing table style * remove unused themeing service * remove more invalid files * add even classes * restore yes-no scss * add even class to process-group-stats-in-out and remote-process-group-received-stats * update table hover and selection styles This closes apache#8707
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
* [NIFI-13095] surface and contrast improvements * [NIFI-12833] primary node icon light/dark mode styling * [NIFI-13101] error page background color now matches light/dark theme * update PG and RPG names to use the material palette contrast color * update listing header text to use the material palette contrast color * update draggable icon hover styles * use surface contrast color for banners * use nifi-surface-default * update to use material primary contrast color for text displayed on top of material surfaces * restore context menu border * restore material theme * fix selected listing table style * remove unused themeing service * remove more invalid files * add even classes * restore yes-no scss * add even class to process-group-stats-in-out and remote-process-group-received-stats * update table hover and selection styles This closes apache#8707
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.