NIFI-13160 Support Skipping Frontend Unit Tests#8757
Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-13160 Support Skipping Frontend Unit Tests#8757exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory wants to merge 1 commit intoapache:mainfrom
Conversation
exceptionfactory
force-pushed
the
NIFI-13160
branch
3 times, most recently
from
f693a2a to
535ba1a
Compare
- Added frontend.skipTests property to nifi-web-frontend Maven configuration with default value of false - Configured lint and unit-test execution goals to depend on frontend.skipTests - Added paths-filter GitHub Actions step for conditional enabling of frontend tests
exceptionfactory
force-pushed
the
NIFI-13160
branch
from
535ba1a to
c7ced93
Compare
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
This closes apache#8757 - Added frontend.skipTests property to nifi-web-frontend Maven configuration with default value of false - Configured lint and unit-test execution goals to depend on frontend.skipTests - Added paths-filter GitHub Actions step for conditional enabling of frontend tests Signed-off-by: Joseph Witt <joewitt@apache.org>
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
This closes apache#8757 - Added frontend.skipTests property to nifi-web-frontend Maven configuration with default value of false - Configured lint and unit-test execution goals to depend on frontend.skipTests - Added paths-filter GitHub Actions step for conditional enabling of frontend tests Signed-off-by: Joseph Witt <joewitt@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-13160 Supports skipping unit tests in the
nifi-web-frontendmodule using a property namedfrontend.skipTests.The property defaults to
false, avoiding running tests on default builds. Changes include adding a paths-filter step to the GitHubci-workflowto support conditional enabling of frontend unit tests when pull requests include changes for thenifi-web-frontendmodule.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkUI Contributions
Licensing
LICENSEandNOTICEfilesDocumentation