NIFI-13164: Moving from jsdom to happy dom for test environment execution#8760
Merged
scottyaslan merged 1 commit intoapache:mainfrom May 7, 2024
Merged
NIFI-13164: Moving from jsdom to happy dom for test environment execution#8760scottyaslan merged 1 commit intoapache:mainfrom
scottyaslan merged 1 commit intoapache:mainfrom
Conversation
- Moving from jsdom to happy dom for test environment execution. - Removing test for the Documentation component that was failing because it was attempting to load an iframe with the nifi documentation that wasn't available.
scottyaslan
approved these changes
May 7, 2024
Contributor
scottyaslan
left a comment
scottyaslan
left a comment
There was a problem hiding this comment.
LGTM. I confirmed that the unit test output no longer displays any errors.
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
- Moving from jsdom to happy dom for test environment execution. - Removing test for the Documentation component that was failing because it was attempting to load an iframe with the nifi documentation that wasn't available. This closes apache#8760
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
- Moving from jsdom to happy dom for test environment execution. - Removing test for the Documentation component that was failing because it was attempting to load an iframe with the nifi documentation that wasn't available. This closes apache#8760
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIFI-13164: