Skip to content

NIFI-13160 Correct frontend changes evaluation in ci-workflow#8761

Closed
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-13160-1
Closed

NIFI-13160 Correct frontend changes evaluation in ci-workflow#8761
exceptionfactory wants to merge 1 commit intoapache:mainfrom
exceptionfactory:NIFI-13160-1

Conversation

@exceptionfactory
Copy link
Contributor

@exceptionfactory exceptionfactory commented May 7, 2024

Summary

NIFI-13160 Corrects evaluation of the steps.changes.outputs.frontend variable in the GitHub ci-workflow when setting the frontend.skipTests build property. The initial implementation always set the frontend.skipTests value to false. The updated approach follows ternary example from GitHub Actions Expressions documentation.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

UI Contributions

  • NiFi is modernizing its UI. Any contributions that update the current UI also need to be implemented in the new UI.

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@asfgit asfgit closed this in b259e2a May 7, 2024
shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
This closes apache#8761.

Signed-off-by: Joseph Witt <joewitt@apache.org>
shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
This closes apache#8761.

Signed-off-by: Joseph Witt <joewitt@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant