Skip to content

NIFI-13186 corrected required runtime dep lucene-backward-codecs and …#8782

Closed
joewitt wants to merge 1 commit intoapache:mainfrom
joewitt:NIFI-13186
Closed

NIFI-13186 corrected required runtime dep lucene-backward-codecs and …#8782
joewitt wants to merge 1 commit intoapache:mainfrom
joewitt:NIFI-13186

Conversation

@joewitt
Copy link
Contributor

@joewitt joewitt commented May 9, 2024

…updated tests

Summary

NIFI-13186

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

UI Contributions

  • NiFi is modernizing its UI. Any contributions that update the current UI also need to be implemented in the new UI.

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@joewitt
Copy link
Contributor Author

joewitt commented May 9, 2024

Validating against m2 built index (lucene 8.11.3) vs this PR. Will share more details.

…updated tests

Updated references to lucene-9 indexes and removed legacy old style indexes.
@joewitt
Copy link
Contributor Author

joewitt commented May 9, 2024

Additional code changes applied now. Tested with a previous build generating Lucene-8 indexes with a range of content. Verified then again post this patch and it picks up where it left off, is still queryable, and continues generating new indexes with the lucene-9 naming. Was able to query both old and new data in the system. Also verifed query syntax still works despite not including the queryparsers module at this point.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing Lucene compatibility with this dependency and code changes @joewitt. I noted two questions regarding particular library removals and one method removal, but otherwise the changes seem straightforward.

shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
- Updated references to lucene-9 indexes and removed legacy old style indexes

This closes apache#8782

Signed-off-by: David Handermann <exceptionfactory@apache.org>i
shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
- Updated references to lucene-9 indexes and removed legacy old style indexes

This closes apache#8782

Signed-off-by: David Handermann <exceptionfactory@apache.org>i
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants