NIFI-13195 Correct Replicated Request Header Removal for HTTP/2#8789
Merged
mcgilman merged 1 commit intoapache:mainfrom May 9, 2024
Merged
NIFI-13195 Correct Replicated Request Header Removal for HTTP/2#8789mcgilman merged 1 commit intoapache:mainfrom
mcgilman merged 1 commit intoapache:mainfrom
Conversation
- Added findHeaderName method to look for header names regardless of casing
Contributor
|
Will review... |
mcgilman
approved these changes
May 9, 2024
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks @exceptionfactory! Changes look good. Verified that the cluster coordinator correctly removes the desired headers and cookies regardless of case. Will merge once CI completes.
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
…ache#8789) - Added findHeaderName method to look for header names regardless of casing This closes apache#8789
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
…ache#8789) - Added findHeaderName method to look for header names regardless of casing This closes apache#8789
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-13195 Corrects HTTP header and cookie removal in the
ThreadPoolRequestReplicatorso that it works as expected regardless of HTTP protocol version.Changes include a new method to find a matching header name regardless of case, which works with both HTTP/1.1 and HTTP/2 requests.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkUI Contributions
Licensing
LICENSEandNOTICEfilesDocumentation