[NIFI-13153] use ellipsis for long component names in dialogs#8802
Merged
mcgilman merged 4 commits intoapache:mainfrom May 10, 2024
Merged
[NIFI-13153] use ellipsis for long component names in dialogs#8802mcgilman merged 4 commits intoapache:mainfrom
mcgilman merged 4 commits intoapache:mainfrom
Conversation
Contributor
scottyaslan
commented
May 10, 2024
scottyaslan
commented
Contributor
|
Reviewing... |
mcgilman
reviewed
May 10, 2024
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks for the PR @scottyaslan! Noticed one minor issue below...
...ages/flow-designer/ui/canvas/items/connection/edit-connection/edit-connection.component.html
Outdated
Show resolved
Hide resolved
mcgilman
approved these changes
May 10, 2024
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks @scottyaslan! Looks good. Will merge once CI completes.
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
…#8802) * [NIFI-13153] use ellipsis for long component names in dialogs * use basis-1/2 * overflow-hidden * remove basis-1/2 and use w-1/2 with padding This closes apache#8802
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
…#8802) * [NIFI-13153] use ellipsis for long component names in dialogs * use basis-1/2 * overflow-hidden * remove basis-1/2 and use w-1/2 with padding This closes apache#8802
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.