NIFI-13211: Decoupling other UIs from exiting NiFi UI#8828
Merged
rfellows merged 10 commits intoapache:mainfrom May 14, 2024
Merged
NIFI-13211: Decoupling other UIs from exiting NiFi UI#8828rfellows merged 10 commits intoapache:mainfrom
rfellows merged 10 commits intoapache:mainfrom
Conversation
- Decoupling the content viewer from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images.
- Decoupling nifi documentation from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images.
- Decoupling nifi image viewer from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images.
- Decoupling nifi standard content viewer from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images.
- Decoupling nifi jolt transform json from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images.
- Decoupling nifi update attribute from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images.
Contributor
|
will review... |
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Quick note regarding license checking, the following two files were flagged as missing the standard license header:
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-content-viewer/src/main/webapp/fonts/flowfont/flowfont.svg
nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-content-viewer/src/main/webapp/fonts/flowfont/flowfont.css
Contributor
Author
Thanks @exceptionfactory. I see I have some |
- Updating rat config.
- Bumping dependency check timeout.
- Since this page is included through the context viewer, the dependency imports must directly reference through its context path.
- Since this page is included through the context viewer, the dependency imports must directly reference through its context path.
rfellows
approved these changes
May 14, 2024
Contributor
rfellows
left a comment
rfellows
left a comment
There was a problem hiding this comment.
Looks good. This sets nifi up to start to transition to the new UI exclusively.
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
* NIFI-13211: - Decoupling the content viewer from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images. * NIFI-13211: - Decoupling nifi documentation from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images. * NIFI-13211: - Decoupling nifi image viewer from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images. * NIFI-13211: - Decoupling nifi standard content viewer from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images. * NIFI-13211: - Decoupling nifi jolt transform json from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images. * NIFI-13211: - Decoupling nifi update attribute from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images. * NIFI-13211: - Updating rat config. * NIFI-13211: - Bumping dependency check timeout. * NIFI-13211: - Since this page is included through the context viewer, the dependency imports must directly reference through its context path. * NIFI-13211: - Since this page is included through the context viewer, the dependency imports must directly reference through its context path. This closes apache#8828
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
* NIFI-13211: - Decoupling the content viewer from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images. * NIFI-13211: - Decoupling nifi documentation from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images. * NIFI-13211: - Decoupling nifi image viewer from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images. * NIFI-13211: - Decoupling nifi standard content viewer from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images. * NIFI-13211: - Decoupling nifi jolt transform json from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images. * NIFI-13211: - Decoupling nifi update attribute from the NiFi UI which is currently pulling in shared dependencies, scripts, styles, and images. * NIFI-13211: - Updating rat config. * NIFI-13211: - Bumping dependency check timeout. * NIFI-13211: - Since this page is included through the context viewer, the dependency imports must directly reference through its context path. * NIFI-13211: - Since this page is included through the context viewer, the dependency imports must directly reference through its context path. This closes apache#8828
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIFI-13211:
NiFi is comprised of numerous UIs that all get deployed at start up. These UIs piggybacked on some shared stylesheets, components, and dependencies by directly loading them through a relative path. In preparation for moving away from the existing UI, these UIs are being updated to bundle these items directly. In time, these UIs will all be modernized as well so this is just a transitional step in that process.