Skip to content

NIFI-13238 - Adding checkstyle rules for whitespaces#8832

Closed
pvillard31 wants to merge 1 commit intoapache:mainfrom
pvillard31:NIFI-13238
Closed

NIFI-13238 - Adding checkstyle rules for whitespaces#8832
pvillard31 wants to merge 1 commit intoapache:mainfrom
pvillard31:NIFI-13238

Conversation

@pvillard31
Copy link
Contributor

Summary

NIFI-13238 - Adding checkstyle rules for whitespaces

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

UI Contributions

  • NiFi is modernizing its UI. Any contributions that update the current UI also need to be implemented in the new UI.

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting in the work to bring some much-needed consistency @pvillard31. The new rules look good, but I noticed the following test failure across platforms:

TestDataTypeUtils.testConvertRecordFieldToObject:422 expected: <4> but was: <4 >

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction, all automated checks are now passing, looks good! +1 merging

shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
This closes apache#8832

Signed-off-by: David Handermann <exceptionfactory@apache.org>
shubhluck pushed a commit to shubhluck/nifi that referenced this pull request Jun 1, 2024
This closes apache#8832

Signed-off-by: David Handermann <exceptionfactory@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants