[NIFI-13241] - extend CloseOnEscpaeDialog in dialogs previously missing it#8833
Merged
scottyaslan merged 2 commits intoapache:mainfrom May 15, 2024
Merged
[NIFI-13241] - extend CloseOnEscpaeDialog in dialogs previously missing it#8833scottyaslan merged 2 commits intoapache:mainfrom
scottyaslan merged 2 commits intoapache:mainfrom
Conversation
Contributor
|
reviewing... |
scottyaslan
requested changes
May 15, 2024
Contributor
scottyaslan
left a comment
scottyaslan
left a comment
There was a problem hiding this comment.
Thanks for the updates. I found a few more dialogs that present the issue:
- create port
- create PG
- create RPG
scottyaslan
approved these changes
May 15, 2024
Contributor
scottyaslan
left a comment
scottyaslan
left a comment
There was a problem hiding this comment.
LGTM will merge once CI completes
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
…ng it (apache#8833) * [NIFI-13241] - extend CloseOnEscpaeDialog in dialogs previously missing it * extend CloseOnEscapeDialog in a few more instances This closes apache#8833
shubhluck
pushed a commit
to shubhluck/nifi
that referenced
this pull request
Jun 1, 2024
…ng it (apache#8833) * [NIFI-13241] - extend CloseOnEscpaeDialog in dialogs previously missing it * extend CloseOnEscapeDialog in a few more instances This closes apache#8833
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIFI-13241
There were a number of dialogs missed in the original pass at supporting escape to close them. This PR adds it to those dialogs.