Ensuring access to the underlying component when accessing property history#884
Closed
mcgilman wants to merge 1 commit intoapache:masterfrom
Closed
Ensuring access to the underlying component when accessing property history#884mcgilman wants to merge 1 commit intoapache:masterfrom
mcgilman wants to merge 1 commit intoapache:masterfrom
Conversation
| // authorize the flow | ||
| authorizeFlow(); | ||
|
|
||
| boolean authorized = false; |
Contributor
There was a problem hiding this comment.
@mcgilman I think we can get rid of this 'authorized' variable all together here. Instead, we can just do a 'return' where we have 'authorized = true' and then we can avoid ever even needing to check it. Seems like it would make the code a little simpler & easier to follow - what you do think?
- Adding additional authorization for accessing component property history.
Contributor
Author
|
Good call @markap14. I've updated the PR accordingly. Thanks! |
Contributor
|
Looks good @mcgilman ! +1 merged to master. |
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIFI-2587: