NIFI-13236 Correct Content-Disposition Filename for Downloads

[exceptionfactory]

Summary

NIFI-13236 Corrects filename encoding for the HTTP Content-Disposition header when downloading files from FlowFile Queues or Provenance event references over HTTP/2.

The HTTP/2 protocol implementation in Jetty 12 includes character encoding validation for HTTP response headers, resulting in an IllegalArgumentException when attempting to write invalid characters. RFC 9110 requires that HTTP header values consist of specific characters in the ASCII character set, so characters outside of the set must be encoded.

The Spring Framework ContentDisposition supports parsing and encoding filename values according to RFC standards. Replacing existing Content-Disposition header formatting with encoded formatting based on the Spring Framework class enables support for extended character sets, such as UTF-8.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

• Apache NiFi Jira issue created

Pull Request Tracking

• Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
• Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

• Pull Request based on current revision of the main branch
• Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

• Build completed using mvn clean install -P contrib-check
  • JDK 21

UI Contributions

• NiFi is modernizing its UI. Any contributions that update the current UI also need to be implemented in the new UI.

Licensing

• New dependencies are compatible with the Apache License 2.0 according to the License Policy
• New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

• Documentation formatting appears as expected in rendered files

[mcgilman]

Will review...

[mcgilman]

Thanks @exceptionfactory! Looks good. Verified it fixes the issue with viewing and downloading content where the filename contains invalid characters.