Skip to content

[NIFI-13539] upgrade to angular 18.0.7#9072

Merged
mcgilman merged 5 commits intoapache:mainfrom
scottyaslan:NIFI-13539
Jul 18, 2024
Merged

[NIFI-13539] upgrade to angular 18.0.7#9072
mcgilman merged 5 commits intoapache:mainfrom
scottyaslan:NIFI-13539

Conversation

@scottyaslan
Copy link
Contributor

No description provided.

@scottyaslan scottyaslan added the ui Pull requests for work relating to the user interface label Jul 10, 2024
@scottyaslan scottyaslan requested a review from mcgilman July 10, 2024 22:21
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on all platforms are failing when invoking the nx command, so it appears something is missing in the configuration.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the particular error, which appears to be related to some conflicting dependency versions:

[INFO] > nifi-frontend@0.0.0 ci
[INFO] > npm ci --ignore-scripts
[INFO] 
[INFO] npm error code ERESOLVE
[INFO] npm error ERESOLVE could not resolve
[INFO] npm error
[INFO] npm error While resolving: @angular-eslint/schematics@17.2.1
[INFO] npm error Found: @angular/cli@18.0.7
[INFO] npm error node_modules/@angular/cli
[INFO] npm error   dev @angular/cli@"~18.0.0" from the root project
[INFO] npm error
[INFO] npm error Could not resolve dependency:
[INFO] npm error peer @angular/cli@">= 17.0.0 < 18.0.0" from @angular-eslint/schematics@17.2.1
[INFO] npm error node_modules/@angular-eslint/schematics
[INFO] npm error   dev @angular-eslint/schematics@"17.2.1" from the root project
[INFO] npm error
[INFO] npm error Conflicting peer dependency: @angular/cli@17.3.8
[INFO] npm error node_modules/@angular/cli
[INFO] npm error   peer @angular/cli@">= 17.0.0 < 18.0.0" from @angular-eslint/schematics@17.2.1
[INFO] npm error   node_modules/@angular-eslint/schematics
[INFO] npm error     dev @angular-eslint/schematics@"17.2.1" from the root project
[INFO] npm error
[INFO] npm error Fix the upstream dependency conflict, or retry
[INFO] npm error this command with --force or --legacy-peer-deps
[INFO] npm error to accept an incorrect (and potentially broken) dependency resolution.

@scottyaslan
Copy link
Contributor Author

Here is the particular error, which appears to be related to some conflicting dependency versions:

[INFO] > nifi-frontend@0.0.0 ci
[INFO] > npm ci --ignore-scripts
[INFO] 
[INFO] npm error code ERESOLVE
[INFO] npm error ERESOLVE could not resolve
[INFO] npm error
[INFO] npm error While resolving: @angular-eslint/schematics@17.2.1
[INFO] npm error Found: @angular/cli@18.0.7
[INFO] npm error node_modules/@angular/cli
[INFO] npm error   dev @angular/cli@"~18.0.0" from the root project
[INFO] npm error
[INFO] npm error Could not resolve dependency:
[INFO] npm error peer @angular/cli@">= 17.0.0 < 18.0.0" from @angular-eslint/schematics@17.2.1
[INFO] npm error node_modules/@angular-eslint/schematics
[INFO] npm error   dev @angular-eslint/schematics@"17.2.1" from the root project
[INFO] npm error
[INFO] npm error Conflicting peer dependency: @angular/cli@17.3.8
[INFO] npm error node_modules/@angular/cli
[INFO] npm error   peer @angular/cli@">= 17.0.0 < 18.0.0" from @angular-eslint/schematics@17.2.1
[INFO] npm error   node_modules/@angular-eslint/schematics
[INFO] npm error     dev @angular-eslint/schematics@"17.2.1" from the root project
[INFO] npm error
[INFO] npm error Fix the upstream dependency conflict, or retry
[INFO] npm error this command with --force or --legacy-peer-deps
[INFO] npm error to accept an incorrect (and potentially broken) dependency resolution.

Thanks @exceptionfactory! This was my first attempt at upgrading the dependencies of our Nx monorepository using their tools to do so and while I did find them helpful it didn't solve all the upgrade issues. I think I have them all sorted now but I will continue babysitting this build until it is green.

Copy link
Contributor

@mcgilman mcgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scottyaslan! Just a couple things noted below.

Copy link
Contributor

@mcgilman mcgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @scottyaslan! Will merge once CI completes.

@mcgilman mcgilman merged commit e205f27 into apache:main Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui Pull requests for work relating to the user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants