[NIFI-13539] upgrade to angular 18.0.7#9072
Conversation
exceptionfactory
left a comment
There was a problem hiding this comment.
Builds on all platforms are failing when invoking the nx command, so it appears something is missing in the configuration.
exceptionfactory
left a comment
There was a problem hiding this comment.
Here is the particular error, which appears to be related to some conflicting dependency versions:
[INFO] > nifi-frontend@0.0.0 ci
[INFO] > npm ci --ignore-scripts
[INFO]
[INFO] npm error code ERESOLVE
[INFO] npm error ERESOLVE could not resolve
[INFO] npm error
[INFO] npm error While resolving: @angular-eslint/schematics@17.2.1
[INFO] npm error Found: @angular/cli@18.0.7
[INFO] npm error node_modules/@angular/cli
[INFO] npm error dev @angular/cli@"~18.0.0" from the root project
[INFO] npm error
[INFO] npm error Could not resolve dependency:
[INFO] npm error peer @angular/cli@">= 17.0.0 < 18.0.0" from @angular-eslint/schematics@17.2.1
[INFO] npm error node_modules/@angular-eslint/schematics
[INFO] npm error dev @angular-eslint/schematics@"17.2.1" from the root project
[INFO] npm error
[INFO] npm error Conflicting peer dependency: @angular/cli@17.3.8
[INFO] npm error node_modules/@angular/cli
[INFO] npm error peer @angular/cli@">= 17.0.0 < 18.0.0" from @angular-eslint/schematics@17.2.1
[INFO] npm error node_modules/@angular-eslint/schematics
[INFO] npm error dev @angular-eslint/schematics@"17.2.1" from the root project
[INFO] npm error
[INFO] npm error Fix the upstream dependency conflict, or retry
[INFO] npm error this command with --force or --legacy-peer-deps
[INFO] npm error to accept an incorrect (and potentially broken) dependency resolution.
Thanks @exceptionfactory! This was my first attempt at upgrading the dependencies of our Nx monorepository using their tools to do so and while I did find them helpful it didn't solve all the upgrade issues. I think I have them all sorted now but I will continue babysitting this build until it is green. |
mcgilman
left a comment
There was a problem hiding this comment.
Thanks @scottyaslan! Just a couple things noted below.
nifi-frontend/src/main/frontend/apps/nifi-jolt-transform-ui/src/app/app.module.ts
Outdated
Show resolved
Hide resolved
nifi-frontend/src/main/frontend/apps/nifi/src/app/app.module.ts
Outdated
Show resolved
Hide resolved
mcgilman
left a comment
There was a problem hiding this comment.
Thanks @scottyaslan! Will merge once CI completes.
No description provided.