[NIFI-13519] allow user to choose to enable, disable, or use device s…#9076
Merged
mcgilman merged 2 commits intoapache:mainfrom Jul 13, 2024
Merged
[NIFI-13519] allow user to choose to enable, disable, or use device s…#9076mcgilman merged 2 commits intoapache:mainfrom
mcgilman merged 2 commits intoapache:mainfrom
Conversation
Contributor
scottyaslan
commented
Jul 11, 2024
scottyaslan
commented
…ettings for animations
Contributor
|
Will review... |
mcgilman
reviewed
Jul 12, 2024
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Nice work @scottyaslan! Just a couple minor items.
nifi-frontend/src/main/frontend/apps/nifi/src/app/ui/common/navigation/navigation.component.ts
Outdated
Show resolved
Hide resolved
nifi-frontend/src/main/frontend/apps/nifi-jolt-transform-ui/src/app/app.module.ts
Show resolved
Hide resolved
mcgilman
approved these changes
Jul 12, 2024
Contributor
mcgilman
left a comment
mcgilman
left a comment
There was a problem hiding this comment.
Thanks @scottyaslan! Will merge once CI completes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.