Skip to content

NIFI-13555: Add verification to HikariDBCPConnectionPool#9085

Merged
exceptionfactory merged 2 commits intoapache:mainfrom
mattyb149:NIFI-13555
Aug 6, 2024
Merged

NIFI-13555: Add verification to HikariDBCPConnectionPool#9085
exceptionfactory merged 2 commits intoapache:mainfrom
mattyb149:NIFI-13555

Conversation

@mattyb149
Copy link
Contributor

Summary

NIFI-13555 This PR adds verifiability to HikariDBCPConnectionPool for added capability and consistency with DBCPConnectionPool

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this improvement @mattyb149, I noted two minor recommendations, but the overall changes look good.

} catch (final SQLException e) {
// If using Kerberos, attempt to re-login
if (kerberosUser != null) {
getLogger().info("Error getting connection, performing Kerberos re-login");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommend including the exception in the log for troubleshooting.

Suggested change
getLogger().info("Error getting connection, performing Kerberos re-login");
getLogger().info("Error getting connection, performing Kerberos re-login", e);

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the feedback @mattyb149, the latest version looks good! +1 merging

@exceptionfactory exceptionfactory merged commit fd8acd5 into apache:main Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants