NIFI-13555: Add verification to HikariDBCPConnectionPool#9085
Merged
exceptionfactory merged 2 commits intoapache:mainfrom Aug 6, 2024
Merged
NIFI-13555: Add verification to HikariDBCPConnectionPool#9085exceptionfactory merged 2 commits intoapache:mainfrom
exceptionfactory merged 2 commits intoapache:mainfrom
Conversation
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for this improvement @mattyb149, I noted two minor recommendations, but the overall changes look good.
| } catch (final SQLException e) { | ||
| // If using Kerberos, attempt to re-login | ||
| if (kerberosUser != null) { | ||
| getLogger().info("Error getting connection, performing Kerberos re-login"); |
Contributor
There was a problem hiding this comment.
Recommend including the exception in the log for troubleshooting.
Suggested change
| getLogger().info("Error getting connection, performing Kerberos re-login"); | |
| getLogger().info("Error getting connection, performing Kerberos re-login", e); |
...ndle/nifi-hikari-dbcp-service/src/main/java/org/apache/nifi/dbcp/HikariCPConnectionPool.java
Outdated
Show resolved
Hide resolved
exceptionfactory
approved these changes
Aug 6, 2024
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for addressing the feedback @mattyb149, the latest version looks good! +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-13555 This PR adds verifiability to HikariDBCPConnectionPool for added capability and consistency with DBCPConnectionPool
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation