Skip to content

[NIFI-13535] - Fix: Issues selecting GitHub branch on version control screens in new UI#9087

Merged
mcgilman merged 3 commits intoapache:mainfrom
rfellows:NIFI-13535-includeBranchWithRegistryCalls
Jul 24, 2024
Merged

[NIFI-13535] - Fix: Issues selecting GitHub branch on version control screens in new UI#9087
mcgilman merged 3 commits intoapache:mainfrom
rfellows:NIFI-13535-includeBranchWithRegistryCalls

Conversation

@rfellows
Copy link
Contributor

NIFI-13535

Properly include the branch query param in API calls to the backend registry API when provided.

@mcgilman mcgilman added the ui Pull requests for work relating to the user interface label Jul 17, 2024
const bucketId = this.importFromRegistryForm.get('bucket')?.value;
this.loadVersions(registryId, bucketId, flowId);
const branch = this.importFromRegistryForm.get('branch')?.value;
this.loadVersions(registryId, bucketId, flowId, branch);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like there is a similar function for bucketChanged which then calls loadFlows(registryId, bucketId) and I think that would need to include the branch as well right?

@bbende
Copy link
Contributor

bbende commented Jul 18, 2024

Also, we need the same behavior on the "Start Version Version Control" screen. I am not sure if that is backed by save-version-dialog.component.ts, but in there I see we have branchChanged which will reload the buckets based on the branch, but we don't have anything for bucketChanged to reload flows, or flowChanged to reload versions. It is possible I am looking at the wrong thing.

@rfellows
Copy link
Contributor Author

Also, we need the same behavior on the "Start Version Version Control" screen. I am not sure if that is backed by save-version-dialog.component.ts, but in there I see we have branchChanged which will reload the buckets based on the branch, but we don't have anything for bucketChanged to reload flows, or flowChanged to reload versions. It is possible I am looking at the wrong thing.

Start version control doesn't load flows or flow versions since we are adding a new flow to the repository. I'm not sure I understand what needs changed there.

Copy link
Contributor

@bbende bbende left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the confusion, you are right about the Start dialog. Latest changes here look good and are working correctly. +1

@mcgilman
Copy link
Contributor

Will review...

Copy link
Contributor

@mcgilman mcgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rfellows!

@mcgilman mcgilman merged commit 2dd7cf7 into apache:main Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui Pull requests for work relating to the user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants