Skip to content

NIFI-13566 Catch Throwable during JettyServer start to ensure any iss…#9101

Closed
bbende wants to merge 1 commit intoapache:mainfrom
bbende:NIFI-13566
Closed

NIFI-13566 Catch Throwable during JettyServer start to ensure any iss…#9101
bbende wants to merge 1 commit intoapache:mainfrom
bbende:NIFI-13566

Conversation

@bbende
Copy link
Contributor

@bbende bbende commented Jul 22, 2024

…ue during start will exit

Summary

NIFI-13566

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@joewitt
Copy link
Contributor

joewitt commented Jul 22, 2024

@bbende What type of exception/Errors were getting through? Out of memory exceptions would do it...

@bbende
Copy link
Contributor Author

bbende commented Jul 22, 2024

@joewitt in this case it was ClassNotFoundError and it left NiFi in a very strange state where the Java process was running and you could even get into the canvas, but trying to add a processor produce some stranger exception. In this case the ClassNotFoundError came from DocGenerator.generate in the middle of the start method.

@joewitt
Copy link
Contributor

joewitt commented Jul 22, 2024

ahh perfect - thanks

@mattyb149
Copy link
Contributor

+1 LGTM, thanks for the improvement! Merging to support/nifi-1.x and main

@mattyb149 mattyb149 closed this in 0e422f0 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants