NIFI-13017: Replace JoltTransformJSON custom UI#9117
Merged
rfellows merged 5 commits intoapache:mainfrom Aug 6, 2024
Merged
Conversation
scottyaslan
reviewed
Jul 26, 2024
Contributor
scottyaslan
left a comment
scottyaslan
left a comment
There was a problem hiding this comment.
A bit unrelated but I noticed that there is an error message the flashes on initial load of the Jolt Custom UI. This is a separate issue and I logged https://issues.apache.org/jira/browse/NIFI-13589 to address that.
10 tasks
- Remove old JoltTransformJSON custom UI. - Update build to use new JoltTransformJSON custom UI. - Fix revision query parameter.
- Excluding jolt transform json ui in workflow ci.
- Excluding jolt nar in workflow ci.
- Excluding jolt ui war from code coverage.
- Incorporating nifi-web-servlet-shared. - Moving QueryStringToFragmentFilter to nifi-web-servlet-shared.
scottyaslan
approved these changes
Aug 6, 2024
Contributor
|
I verified that purple mode works well and that the browser back button navigation is fixed. Nice work @mcgilman! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NIFI-13017: