[NIFI-13589] improve loading and error handling for jolt UI#9155
Merged
rfellows merged 4 commits intoapache:mainfrom Aug 15, 2024
Merged
[NIFI-13589] improve loading and error handling for jolt UI#9155rfellows merged 4 commits intoapache:mainfrom
rfellows merged 4 commits intoapache:mainfrom
Conversation
Contributor
scottyaslan
commented
Aug 6, 2024
scottyaslan
commented
Contributor
|
The snackbar error is a bit strange in this case. I think it would be better to just put it back to how it was before and show a full screen error since the page is not useable at all. |
scottyaslan
force-pushed
the
NIFI-13589
branch
from
952dab3 to
b080098
Compare
rfellows
approved these changes
Aug 15, 2024
Contributor
rfellows
left a comment
rfellows
left a comment
There was a problem hiding this comment.
Looks good @scottyaslan. Thanks for the update.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.