Skip to content

NIFI-13649 Ensure cluster node API address is reachable before markin…#9168

Merged
exceptionfactory merged 4 commits intoapache:mainfrom
bbende:NIFI-13649
Aug 12, 2024
Merged

NIFI-13649 Ensure cluster node API address is reachable before markin…#9168
exceptionfactory merged 4 commits intoapache:mainfrom
bbende:NIFI-13649

Conversation

@bbende
Copy link
Contributor

@bbende bbende commented Aug 9, 2024

…g CONNECTED

Summary

NIFI-13649

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for introducing the improvements here @bbende. I noted a concern regarding the isReachable() method behavior, and I think an alternative approach using a basic Socket connection would be more reliable across platforms.

@bbende
Copy link
Contributor Author

bbende commented Aug 12, 2024

Thanks @exceptionfactory , pushed an update to address the feedback

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments @bbende, the latest version looks good! +1 merging

@exceptionfactory exceptionfactory merged commit e349b7e into apache:main Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants