NIFI-13649 Ensure cluster node API address is reachable before markin…#9168
Merged
exceptionfactory merged 4 commits intoapache:mainfrom Aug 12, 2024
Merged
NIFI-13649 Ensure cluster node API address is reachable before markin…#9168exceptionfactory merged 4 commits intoapache:mainfrom
exceptionfactory merged 4 commits intoapache:mainfrom
Conversation
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for introducing the improvements here @bbende. I noted a concern regarding the isReachable() method behavior, and I think an alternative approach using a basic Socket connection would be more reliable across platforms.
...r/src/main/java/org/apache/nifi/cluster/coordination/heartbeat/AbstractHeartbeatMonitor.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/org/apache/nifi/cluster/coordination/heartbeat/AbstractHeartbeatMonitor.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks @exceptionfactory , pushed an update to address the feedback |
exceptionfactory
approved these changes
Aug 12, 2024
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustments @bbende, the latest version looks good! +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g CONNECTED
Summary
NIFI-13649
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation