NIFI-13670: Improve sensitive value editing.#9191
Merged
scottyaslan merged 3 commits intoapache:mainfrom Aug 26, 2024
Merged
Conversation
Contributor
mcgilman
commented
Aug 21, 2024
mcgilman
commented
- Do not present the user with the masked value.
- Do not use the masked value when determining if a value has changed.
- Do not include the masked value in the payload if the value hasn't changed.
- Do not present the user with the masked value. - Do not use the masked value when determining if a value has changed. - Do not include the masked value in the payload if the value hasn't changed. - Updates to ParameterItem model to more easily track changes.
scottyaslan
approved these changes
Aug 26, 2024
Contributor
scottyaslan
left a comment
scottyaslan
left a comment
There was a problem hiding this comment.
These changes work well. Thanks @mcgilman! +1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.