NIFI-13681 Fix Kubernetes coordination environment variable names#9199
Merged
exceptionfactory merged 2 commits intoapache:mainfrom Aug 27, 2024
Merged
NIFI-13681 Fix Kubernetes coordination environment variable names#9199exceptionfactory merged 2 commits intoapache:mainfrom
exceptionfactory merged 2 commits intoapache:mainfrom
Conversation
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
@malthe Thanks for the contribution. I am in favor of this change as it aligns the environment variable name with the property name.
Every change needs a corresponding Apache NiFi Jira issue, so if you can create the Jira issue, then update the pull request title and commit messages with the Jira issue number, this should be ready to go forward.
Contributor
Author
|
@exceptionfactory done! |
exceptionfactory
approved these changes
Aug 27, 2024
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks again for linking the Jira issue @malthe! +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-13681
The Kubernetes-related coordination settings draw on environment variables that do not accurately reflect their property names, leading to confusion.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation