NIFI-2459: HTTP Site-to-Site can't update remote peer topology if the "bootstrap url" node is down #927
Closed
ijokarumawak wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-2459: HTTP Site-to-Site can't update remote peer topology if the "bootstrap url" node is down #927ijokarumawak wants to merge 1 commit intoapache:masterfrom
ijokarumawak wants to merge 1 commit intoapache:masterfrom
Conversation
Refresh remote peer statuses even if the bootstrap node goes down. Migrate existing code which handles the situation from EndpointConnectionPool to PeerSelector, so that both RAW and HTTP transport protocol has the same capability.
Contributor
|
@ijokarumawak excellent - thanks for getting this in! Code looks good. Will do some verification and then if all looks good will push to master. |
Contributor
|
Looks good. Was able to verify the behavior and the results were exactly as expected! A big thanks for tackling this! +1 merged to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates existing code which handles the situation, from EndpointConnectionPool to PeerSelector, so that both RAW and HTTP transport protocol has the same capability.
Added a unit test to confirm this scenario.
Also did an IT test using running NiFi cluster:
Used a 3 node cluster. Setup S2S specifying node 2 as the bootstrap node, then stop node 2. Confirm data is sent to only node 1 and 3. Remote peer status can still be refreshed. Then add Node 2 back, Confirm data is sent to node 1, 2 and 3.