NIFI-13722: Kerberos ticket renewal issue due static thread pool in Iceberg library (nifi-1.x)#9305
Closed
mark-bathori wants to merge 1 commit intoapache:support/nifi-1.xfrom
Closed
NIFI-13722: Kerberos ticket renewal issue due static thread pool in Iceberg library (nifi-1.x)#9305mark-bathori wants to merge 1 commit intoapache:support/nifi-1.xfrom
mark-bathori wants to merge 1 commit intoapache:support/nifi-1.xfrom
Conversation
dan-s1
reviewed
Sep 23, 2024
Comment on lines
+86
to
+91
| KerberosUser kerberosUser; | ||
| if (kerberosUserReference.get() == null) { | ||
| kerberosUser = kerberosUserService.createKerberosUser(); | ||
| } else { | ||
| kerberosUser = kerberosUserReference.get(); | ||
| } |
Contributor
There was a problem hiding this comment.
Just call get() once
Suggested change
| KerberosUser kerberosUser; | |
| if (kerberosUserReference.get() == null) { | |
| kerberosUser = kerberosUserService.createKerberosUser(); | |
| } else { | |
| kerberosUser = kerberosUserReference.get(); | |
| } | |
| KerberosUser kerberosUser = kerberosUserReference.get() ; | |
| if (kerberosUser == null) { | |
| kerberosUser = kerberosUserService.createKerberosUser(); | |
| } |
| getLogger().error("Privileged action failed with kerberos user " + kerberosUser, e); | ||
| session.transfer(session.penalize(flowFile), REL_FAILURE); | ||
| if (!handleAuthErrors(e, session, context)) { | ||
| getLogger().error("Privileged action failed with kerberos user " + kerberosUser, e); |
Contributor
There was a problem hiding this comment.
Use interpolation and not concatenation.
Suggested change
| getLogger().error("Privileged action failed with kerberos user " + kerberosUser, e); | |
| getLogger().error("Privileged action failed with kerberos user {}" , kerberosUser, e); |
Contributor
Author
|
Thanks @dan-s1 for the comments. This is a backport PR so these changes are already merged into the main branch. To keep the consistency between the two branch I would keep the changes as it is, but your requested changes could be done in a separate PR if necessary. |
turcsanyip
approved these changes
Sep 24, 2024
Contributor
turcsanyip
left a comment
turcsanyip
left a comment
There was a problem hiding this comment.
As per @mark-bathori comment, it is a backport PR and I would also keep it as it is.
Thanks @dan-s1 for your review comments, I overlooked them in the original review on the main branch. We can address them in a follow-up PR or next time when we touch the Iceberg processors.
+1 Merging this for now.
turcsanyip
pushed a commit
that referenced
this pull request
Sep 24, 2024
…ceberg library This closes #9305. Signed-off-by: Peter Turcsanyi <turcsanyi@apache.org>
Contributor
|
Merged. |
takraj
pushed a commit
to takraj/nifi
that referenced
this pull request
Mar 17, 2025
…ceberg library This closes apache#9305. Signed-off-by: Peter Turcsanyi <turcsanyi@apache.org> (cherry picked from commit a0ec730)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-13722
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation