NIFI-2642 Catches (and ignores) ResourceNotFoundException during the …#931
Closed
jtstorck wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-2642 Catches (and ignores) ResourceNotFoundException during the …#931jtstorck wants to merge 1 commit intoapache:masterfrom
jtstorck wants to merge 1 commit intoapache:masterfrom
Conversation
…updating of a property value for a controller service when the current value points to a controller service that has been deleted, allowing the assigning of a new controller service to continue.
Contributor
|
Reviewing |
| final Authorizable currentServiceAuthorizable = lookup.getControllerService(currentValue).getAuthorizable(); | ||
| currentServiceAuthorizable.authorize(authorizer, RequestAction.READ, user); | ||
| } catch (ResourceNotFoundException e) { | ||
| // ignore if the resource is not found, if currentValue was previously deleted, it should not stop assignment of proposedValue |
Contributor
There was a problem hiding this comment.
I wonder if instead of raising and then catching exception and do nothing we should instead introduce canLocate(id) or isLocatable?
Contributor
Author
There was a problem hiding this comment.
That section of code can still raise an AccessDeniedException, we're just ignoring the RNFE in this specific case. There are probably other cases where the RNFE would bubble up to the UI, where the exception mapper would handle it properly, but in this case it was preventing the new controller service to be assigned. I think for 1.0.0, this is the best fix.
asfgit
pushed a commit
that referenced
this pull request
Sep 10, 2016
Added 'file.lastModifiedTime' attribute to ListFileTransfer, which is the abstract class extended by ListSFTP. String literal attribute names were replaced with static references to attribute name constants in ListFile. ListFileTransfer stores the 'file.lastModifiedTime' attribute in the format specified in ListFile.FILE_MODIFY_DATE_ATTR_FORMAT Updated WritesAttribute description for file last modify time attribute to mirror the entry in ListFile Signed-off-by: Joe Skora <jskora@gmail.com> This closes #931.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…updating of a property value for a controller service when the current value points to a controller service that has been deleted, allowing the assigning of a new controller service to continue.