NIFI-13811: Fix CalculateRecordStats so that it can properly handle a…#9321
Closed
markap14 wants to merge 1 commit intoapache:mainfrom
Closed
NIFI-13811: Fix CalculateRecordStats so that it can properly handle a…#9321markap14 wants to merge 1 commit intoapache:mainfrom
markap14 wants to merge 1 commit intoapache:mainfrom
Conversation
…rrays of nested records; clarified documentation / code cleanup
EndzeitBegins
approved these changes
Sep 28, 2024
Contributor
EndzeitBegins
left a comment
EndzeitBegins
left a comment
There was a problem hiding this comment.
Code changes look good to me.
Thank you for refactoring some names for improved readability.
You could use List.of for schema declaration in tests instead of ArrayList, but that's just a matter of preference.
Other than that I just have one small remark regarding a variable name.
| } catch (Exception ex) { | ||
| getLogger().error("Error processing stats.", ex); | ||
| session.transfer(input, REL_FAILURE); | ||
| final Map<String, RecordPath> recordPath = getRecordPaths(context, flowFile); |
Contributor
There was a problem hiding this comment.
Did you use the singular form here on purpose or accidentally? I'd prefer recordPaths over recordPath.
exceptionfactory
approved these changes
Oct 11, 2024
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the fixes and improvements @markap14! The overall set of changes look good, I'll adjust the name of the recordPath variable to recordPaths in the merge. +1
| } catch (Exception ex) { | ||
| getLogger().error("Error processing stats.", ex); | ||
| session.transfer(input, REL_FAILURE); | ||
| final Map<String, RecordPath> recordPath = getRecordPaths(context, flowFile); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rrays of nested records; clarified documentation / code cleanup
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation