NIFI-2662 - Fix style violations previously missed#941
Closed
trixpan wants to merge 1 commit intoapache:masterfrom
Closed
NIFI-2662 - Fix style violations previously missed#941trixpan wants to merge 1 commit intoapache:masterfrom
trixpan wants to merge 1 commit intoapache:masterfrom
Conversation
Contributor
Author
Contributor
|
@trixpan please don't merge this in. I want to make sure all the changes in PR 933 are accounted for first and if they are the check style issues should go away. |
Contributor
Author
|
@JPercivall - no worries at all. Please note PR940 is already live so we may be worth checking that as well |
Contributor
|
@trixpan @JPercivall I've opened a new #943 that is rebased against current master. The commits that were lost did address the contrib check issues along with some other features/bugs. Since we needed to account for the other changes that were lost, can we close out this PR and related JIRA in favor of the #943. I've already reopened NIFI-2635. Thanks! |
Contributor
Author
|
closed as per @mcgilman request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix styles missed during PR940