NIFI-13988 Refactored number handling to account for a blank string and treat it as a null when the inferred type is a number.#9511
Merged
exceptionfactory merged 2 commits intoapache:mainfrom Nov 12, 2024
Conversation
…nd treat it as a null when the inferred type is a number.
exceptionfactory
requested changes
Nov 12, 2024
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for implementing this improvement @dan-s1. The general approach of treating an empty string as null for numbers looks good.
Based on the usage, it looks like the string == null check is unnecessary since it should never be null based on the existing uses.
...mmons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
Outdated
Show resolved
Hide resolved
10 tasks
exceptionfactory
approved these changes
Nov 12, 2024
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustments @dan-s1, looks good! +1 merging
KalmanJantner
pushed a commit
to KalmanJantner/nifi
that referenced
this pull request
Feb 11, 2025
… null (apache#9511) Signed-off-by: David Handermann <exceptionfactory@apache.org> (cherry picked from commit 2f048ca)
iadamcsik
pushed a commit
to iadamcsik/nifi
that referenced
this pull request
Oct 22, 2025
… null (apache#9511) Signed-off-by: David Handermann <exceptionfactory@apache.org> (cherry picked from commit 2f048ca)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-13988
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation