NIFI-14007 Add ACL entities to GCS Processor FlowFile attributes.#9520
Merged
exceptionfactory merged 2 commits intoapache:mainfrom Nov 15, 2024
Merged
NIFI-14007 Add ACL entities to GCS Processor FlowFile attributes.#9520exceptionfactory merged 2 commits intoapache:mainfrom
exceptionfactory merged 2 commits intoapache:mainfrom
Conversation
237779e to
9ea398f
Compare
9ea398f to
e08783f
Compare
exceptionfactory
requested changes
Nov 14, 2024
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the improvement @alexethier. This looks like a helpful change, but several GCS unit tests are now failing, so those need to be addressed.
- Fixed tests - Added unit tests for file ACLs
f7ed156 to
3015883
Compare
Contributor
Author
|
@exceptionfactory oops my bad! I've added unit tests and fixed the erroring ones. |
exceptionfactory
approved these changes
Nov 15, 2024
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for updating the unit tests @alexethier, the latest version looks good! +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GCS file's ACL identities and roles to ListGCSBucket and FetchGCSObject processor's FlowFile Attribute output.
Summary
NIFI-14007
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-check