Skip to content

NIFI-14007 Add ACL entities to GCS Processor FlowFile attributes.#9520

Merged
exceptionfactory merged 2 commits intoapache:mainfrom
alexethier:NIFI-14007
Nov 15, 2024
Merged

NIFI-14007 Add ACL entities to GCS Processor FlowFile attributes.#9520
exceptionfactory merged 2 commits intoapache:mainfrom
alexethier:NIFI-14007

Conversation

@alexethier
Copy link
Copy Markdown
Contributor

@alexethier alexethier commented Nov 14, 2024

Add GCS file's ACL identities and roles to ListGCSBucket and FetchGCSObject processor's FlowFile Attribute output.

Summary

NIFI-14007

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
  • JDK 21

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement @alexethier. This looks like a helpful change, but several GCS unit tests are now failing, so those need to be addressed.

- Fixed tests
- Added unit tests for file ACLs
@alexethier
Copy link
Copy Markdown
Contributor Author

@exceptionfactory oops my bad! I've added unit tests and fixed the erroring ones.

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the unit tests @alexethier, the latest version looks good! +1 merging

@exceptionfactory exceptionfactory merged commit 2173672 into apache:main Nov 15, 2024
KalmanJantner pushed a commit to KalmanJantner/nifi that referenced this pull request Feb 11, 2025
…che#9520)

Signed-off-by: David Handermann <exceptionfactory@apache.org>
(cherry picked from commit 2173672)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants