NIFI-14041 - Improve MockPropertyValue and EL evaluation validation#9549
Merged
exceptionfactory merged 2 commits intoapache:mainfrom Nov 25, 2024
Merged
NIFI-14041 - Improve MockPropertyValue and EL evaluation validation#9549exceptionfactory merged 2 commits intoapache:mainfrom
exceptionfactory merged 2 commits intoapache:mainfrom
Conversation
exceptionfactory
requested changes
Nov 22, 2024
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for improving this behavior @pvillard31. The changes look good, just noted some syntax improvement recommendations in the test class.
nifi-mock/src/test/java/org/apache/nifi/util/TestMockPropertyValue.java
Outdated
Show resolved
Hide resolved
nifi-mock/src/test/java/org/apache/nifi/util/TestMockPropertyValue.java
Outdated
Show resolved
Hide resolved
nifi-mock/src/test/java/org/apache/nifi/util/TestMockPropertyValue.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Thanks for reviewing @exceptionfactory - pushed a commit to address your comments |
exceptionfactory
approved these changes
Nov 25, 2024
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustments @pvillard31! +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14041 - Improve MockPropertyValue and EL evaluation validation
While building a processor, I noticed that the test framework would throw an error if I'm in the below situation:
This should not throw an error. This PR is to fix this case as well as covering the overall EL evaluation in the test framework with proper unit testing.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation