added PutMultiTableDatabaseRecord processor#9574
added PutMultiTableDatabaseRecord processor#9574oschakravarthi wants to merge 1 commit intoapache:mainfrom
Conversation
|
Thanks for the contribution @oschakravarthi , please create a JIRA ticket describing the change and update this PR to link to the JIRA. It would also help to add unit test for the processor using NiFi's mock testing framework. |
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the contribution @oschakravarthi.
As it stands, the initial version of this Processor has significant overlap with existing components. It also reflects a large number of historical issues with the existing PutDatabaseRecord Processor in terms of type handling and other issues.
For these reasons, it would require significant refactoring for this to go forward.
I will leave the pull request open for the moment as an opportunity for initial discussion. However, as @bbende mentioned, please create a Jira issue and summarize the features desired and the gaps in the present set of components that prompt this new proposal. We can discuss implementation issues in Jira, and then consider the code itself.
Depending on initial discussion, it may be necessary to close this pull request and revisit when there is a clearer path forward.
|
I agree with @bbende and @exceptionfactory 's comments. Perhaps a different approach could be to add a property to PutDatabaseRecord on whether Table Name contains a "literal" or a RecordPath. If RecordPath is chosen, a dependent property could appear for the user to enter the RecordPath to the table name to be used much like we do for "Use Record Path" options in other properties in PutDatabaseRecord. We can continue this discussion once there is a Jira in place. |
|
Thanks for the comments! @oschakravarthi feel free to request a Jira account through the self-serve portal and we can continue the discussion after you submit a new Jira issue regarding potential changes. |
Summary
NIFI-00000
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation