Skip to content

added PutMultiTableDatabaseRecord processor#9574

Closed
oschakravarthi wants to merge 1 commit intoapache:mainfrom
oschakravarthi:main
Closed

added PutMultiTableDatabaseRecord processor#9574
oschakravarthi wants to merge 1 commit intoapache:mainfrom
oschakravarthi:main

Conversation

@oschakravarthi
Copy link
Copy Markdown

@oschakravarthi oschakravarthi commented Dec 10, 2024

Summary

NIFI-00000

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@bbende
Copy link
Copy Markdown
Contributor

bbende commented Dec 10, 2024

Thanks for the contribution @oschakravarthi , please create a JIRA ticket describing the change and update this PR to link to the JIRA. It would also help to add unit test for the processor using NiFi's mock testing framework.

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @oschakravarthi.

As it stands, the initial version of this Processor has significant overlap with existing components. It also reflects a large number of historical issues with the existing PutDatabaseRecord Processor in terms of type handling and other issues.

For these reasons, it would require significant refactoring for this to go forward.

I will leave the pull request open for the moment as an opportunity for initial discussion. However, as @bbende mentioned, please create a Jira issue and summarize the features desired and the gaps in the present set of components that prompt this new proposal. We can discuss implementation issues in Jira, and then consider the code itself.

Depending on initial discussion, it may be necessary to close this pull request and revisit when there is a clearer path forward.

@mattyb149
Copy link
Copy Markdown
Contributor

I agree with @bbende and @exceptionfactory 's comments. Perhaps a different approach could be to add a property to PutDatabaseRecord on whether Table Name contains a "literal" or a RecordPath. If RecordPath is chosen, a dependent property could appear for the user to enter the RecordPath to the table name to be used much like we do for "Use Record Path" options in other properties in PutDatabaseRecord. We can continue this discussion once there is a Jira in place.

@exceptionfactory
Copy link
Copy Markdown
Contributor

Thanks for the comments!

@oschakravarthi feel free to request a Jira account through the self-serve portal and we can continue the discussion after you submit a new Jira issue regarding potential changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants