NIFI-14117 - PublishKafka should send default attribute as key if cus…#9608
Merged
exceptionfactory merged 2 commits intoapache:mainfrom Jan 6, 2025
Merged
NIFI-14117 - PublishKafka should send default attribute as key if cus…#9608exceptionfactory merged 2 commits intoapache:mainfrom
exceptionfactory merged 2 commits intoapache:mainfrom
Conversation
…tom attribute not specified
exceptionfactory
requested changes
Jan 6, 2025
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for addressing this issue and adding the test @greyp9. One minor recommendation is to move the key attribute selection logic to the constructor, instead of the getKey method invocation. Otherwise this looks good.
| @Override | ||
| public byte[] getKey(final Map<String, String> attributes, final Record record) throws UnsupportedEncodingException { | ||
| final String keyAttributeValue = (keyAttribute == null) ? null : attributes.get(keyAttribute); | ||
| final String keyAttributeEffective = (keyAttribute == null) ? KafkaFlowFileAttribute.KAFKA_KEY : keyAttribute; |
Contributor
There was a problem hiding this comment.
For clarity, it looks like this logic could be handled in the constructor, instead of on every method invocation.
Contributor
Author
There was a problem hiding this comment.
Thanks; sure. Believe it or not, I went back and forth about which style was better :)
exceptionfactory
approved these changes
Jan 6, 2025
Contributor
exceptionfactory
left a comment
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustment @greyp9, looks good! +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tom attribute not specified
Summary
NIFI-14117
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation