[NIFI-14185] - upgrade angular 19, nx 20#9669
Merged
scottyaslan merged 7 commits intoapache:mainfrom Jan 31, 2025
Merged
Conversation
…tion expansion panel scrolling, minor compile issues
scottyaslan
reviewed
Jan 31, 2025
...d/src/main/frontend/apps/nifi/src/app/pages/documentation/feature/documentation.component.ts
Outdated
Show resolved
Hide resolved
scottyaslan
approved these changes
Jan 31, 2025
Contributor
scottyaslan
left a comment
scottyaslan
left a comment
There was a problem hiding this comment.
LGTM! Will merge once CI completes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14185
Migrated to Nx latest (20). This also upgraded to Angular 19. This PR is everything required for those changes to be complete.
In angular 19, the default component type is standalone. So if you do not declare it
standalone: false, it will be true. This change had ramifications including needing to upgrade some 3rd party components to make them compatible as well as relaxing an eslint rule from error to warn when declaring a component asstandalone: false.There were a couple of new compiler errors that showed up as a result of the upgrade too. These were solved in this PR as well.
One particular change to mention, the mat-expand-panel had some behavior changes that made scrolling the contents of the documentation panel on load not work properly. You will see in this PR that we now initialize state of the desired expanded panel based on the current route and control its expanded state through properties on the class rather than assume the
openAllmethod on the accordion will complete in time before the attempt to scroll happens.Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranch