Skip to content

Conversation

@rfellows
Copy link
Contributor

@rfellows rfellows commented Feb 5, 2025

Summary

NIFI-14241
Replace deprecated imports of setup-jest with new approach

Migrated to use

setupZoneTestEnv({
    errorOnUnknownElements: true,
    errorOnUnknownProperties: true
});

@rfellows rfellows added the ui Pull requests for work relating to the user interface label Feb 5, 2025
@rfellows rfellows requested a review from scottyaslan February 5, 2025 20:24
@github-actions
Copy link

github-actions bot commented Jun 6, 2025

Automated review is marking this PR as stale due to lack of updates in the past four months. This PR will be closed in 15 days if the stale label is not removed. This stale label and automated closure does not indicate a judgement of the PR, just lack of reviewer bandwidth and helps us keep the PR queue more manageable. If you would like this PR re-opened you can do so and a committer can remove the stale label. Or you can open a new PR. Try to help review other PRs to increase PR review bandwidth which in turn helps yours.

@github-actions github-actions bot added the Stale label Jun 6, 2025
RouterTestingModule,
MockComponent(BannerText),
MockComponent(Navigation),
MockComponent(NgxSkeletonLoaderComponent)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this component uses the skeleton loader so mocking here shouldn't be needed. I realize this PR been open for some time so it's possible the components changed since opening.

Copy link
Contributor

@mcgilman mcgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @rfellows! Will merge once CI complets.

@mcgilman mcgilman merged commit 7c6a534 into apache:main Jun 6, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Stale ui Pull requests for work relating to the user interface

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants