Skip to content

NIFI-14257: Adding additional scopes for ListenSlack on Message Events and new WritesAttribute#9713

Closed
ncover21 wants to merge 1 commit intoapache:mainfrom
ncover21:NIFI-14257
Closed

NIFI-14257: Adding additional scopes for ListenSlack on Message Events and new WritesAttribute#9713
ncover21 wants to merge 1 commit intoapache:mainfrom
ncover21:NIFI-14257

Conversation

@ncover21
Copy link
Contributor

@ncover21 ncover21 commented Feb 11, 2025

Add additional scopes for "Receive Message Event" event type in ListenSlack connector:

  • FileChangedEvent
  • MessageChangedEvent
  • ReactionAddedEvent

Add flowFile attribute for event type to route on.

Summary

NIFI-14257

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

@ncover21 ncover21 marked this pull request as ready for review February 11, 2025 18:57
Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution @ncover21 !

The change LGTM and I'm +1 assuming the checks are green. However I did leave a comment regarding additional event types that could be worth considering as part of this change.

Copy link
Contributor

@pvillard31 pvillard31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, will merge assuming checks are green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants