Skip to content

NIFI-14285 ConsumeKinesisStream Record Wrapper#9738

Merged
exceptionfactory merged 6 commits into
apache:mainfrom
dariuszseweryn:NIFI-14285
Mar 4, 2025
Merged

NIFI-14285 ConsumeKinesisStream Record Wrapper#9738
exceptionfactory merged 6 commits into
apache:mainfrom
dariuszseweryn:NIFI-14285

Conversation

@dariuszseweryn
Copy link
Copy Markdown
Contributor

Summary

NIFI-14285

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-14285
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-14285

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • (no new) New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • (no new) New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for introducing this new property support @dariuszseweryn. The general approach looks good. I noted a few implementation detail recommendations.

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the updates @dariuszseweryn, this looks close to completion, just noted two more items to address.

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @dariuszseweryn, one more recommendation related to property ordering, and then this looks ready to go.

Copy link
Copy Markdown
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for implementing the new feature for Kinesis Streaming @dariuszseweryn, looks good! +1 merging

@exceptionfactory exceptionfactory merged commit 6d7805f into apache:main Mar 4, 2025
@dariuszseweryn dariuszseweryn deleted the NIFI-14285 branch June 6, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants