NIFI-14285 ConsumeKinesisStream Record Wrapper#9738
Merged
Conversation
1e01ced to
87d3bf9
Compare
exceptionfactory
requested changes
Feb 26, 2025
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for introducing this new property support @dariuszseweryn. The general approach looks good. I noted a few implementation detail recommendations.
exceptionfactory
requested changes
Mar 1, 2025
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the updates @dariuszseweryn, this looks close to completion, just noted two more items to address.
exceptionfactory
requested changes
Mar 4, 2025
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for the updates @dariuszseweryn, one more recommendation related to property ordering, and then this looks ready to go.
exceptionfactory
approved these changes
Mar 4, 2025
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks again for implementing the new feature for Kinesis Streaming @dariuszseweryn, looks good! +1 merging
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14285
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-14285NIFI-14285Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation