Skip to content

NIFI-14284 ConsumeKinesisStream migrate property names to new convention#9741

Merged
exceptionfactory merged 4 commits intoapache:mainfrom
dariuszseweryn:NIFI-14284
Feb 25, 2025
Merged

NIFI-14284 ConsumeKinesisStream migrate property names to new convention#9741
exceptionfactory merged 4 commits intoapache:mainfrom
dariuszseweryn:NIFI-14284

Conversation

@dariuszseweryn
Copy link
Contributor

Summary

NIFI-14284

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-14284
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-14284

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • (no new) New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • (no new) New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • (no changes) Documentation formatting appears as expected in rendered files

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this modernization for property names @dariuszseweryn. The changes look good, but the displayName() call can also be removed.

Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the adjustments @dariuszseweryn, the latest version looks good! +1 merging

@exceptionfactory exceptionfactory merged commit 71d244d into apache:main Feb 25, 2025
6 checks passed
@dariuszseweryn dariuszseweryn deleted the NIFI-14284 branch June 6, 2025 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants