Skip to content

NIFI-14099 Adjust GetHDFSTest to use TempDir for test files#9743

Closed
exceptionfactory wants to merge 2 commits intoapache:mainfrom
exceptionfactory:NIFI-14099
Closed

NIFI-14099 Adjust GetHDFSTest to use TempDir for test files#9743
exceptionfactory wants to merge 2 commits intoapache:mainfrom
exceptionfactory:NIFI-14099

Conversation

@exceptionfactory
Copy link
Contributor

Summary

NIFI-14099 Adjusts the behavior of GetHDFSTest to use the JUnit TempDir annotated path for the source of reading files. This approach avoids depending on the timestamp of files located in the source directory itself, making the tests more reliable based on expected creation times.

Additional changes include removing a duplicative test for a directory defined using expression language in the property value.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

- Copying files from test resources to TempDir avoids failures based on file creation timestamps
Copy link
Contributor

@mark-bathori mark-bathori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again @exceptionfactory for this improvement, changes looks good now.
LGTM+1
Merging.

@asfgit asfgit closed this in d018675 Feb 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants