NIFI-14099 Adjust GetHDFSTest to use TempDir for test files#9743
Closed
exceptionfactory wants to merge 2 commits intoapache:mainfrom
Closed
NIFI-14099 Adjust GetHDFSTest to use TempDir for test files#9743exceptionfactory wants to merge 2 commits intoapache:mainfrom
exceptionfactory wants to merge 2 commits intoapache:mainfrom
Conversation
- Copying files from test resources to TempDir avoids failures based on file creation timestamps
...bundle/nifi-hdfs-processors/src/test/java/org/apache/nifi/processors/hadoop/GetHDFSTest.java
Show resolved
Hide resolved
mark-bathori
approved these changes
Feb 25, 2025
Contributor
mark-bathori
left a comment
There was a problem hiding this comment.
Thanks again @exceptionfactory for this improvement, changes looks good now.
LGTM+1
Merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14099 Adjusts the behavior of
GetHDFSTestto use the JUnitTempDirannotated path for the source of reading files. This approach avoids depending on the timestamp of files located in the source directory itself, making the tests more reliable based on expected creation times.Additional changes include removing a duplicative test for a directory defined using expression language in the property value.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation