NIFI-14303 Additional metadata attributes in ListGoogleDrive#9753
NIFI-14303 Additional metadata attributes in ListGoogleDrive#9753turcsanyip wants to merge 1 commit intoapache:mainfrom
Conversation
Introduced optionally configurable metadata attributes in ListGoogleDrive Added drive.created.time and drive.modified.time in List/Fetch/PutGoogleDrive Fixed drive.timestamp in Fetch/PutGoogleDrive
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for working on these improvements to provide additional metadata from Google Drive @turcsanyip.
Including the metadata seems helpful, but I'm not sure about making a configurable property for which attributes should be included. It seems simpler to always include the metadata. Is there a particular reason for providing the fine-grained level of control over the output?
I'm also wondering about the Folder Separator property, as it seems potentially confusing based on the description. It sounds like it requires some background knowledge of what will be listed, which seems like a dangerous assumption for continuous flows. Instead of making this configurable, it seems that a better approach would be some type of encoding strategy. Using URL encoding seems like the most obvious choice, which would support a standard / separator, and encode that character when it is part of file or folder names. There may be other options, but that is one that comes to mind.
.../nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/ListGoogleDrive.java
Show resolved
Hide resolved
.../nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/ListGoogleDrive.java
Show resolved
Hide resolved
.../nifi-gcp-processors/src/main/java/org/apache/nifi/processors/gcp/drive/ListGoogleDrive.java
Show resolved
Hide resolved
|
@exceptionfactory Created new PR with new attributes statically added and URL encoded folder names: #9779 |
Introduced optionally configurable metadata attributes in ListGoogleDrive Added drive.created.time and drive.modified.time in List/Fetch/PutGoogleDrive Fixed drive.timestamp in Fetch/PutGoogleDrive
Summary
NIFI-14303
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation