Skip to content

NIFI-14312 Made improvements to TestIdentifyMimeType by reducing duplicated code and introducing paramaterized tests.#9762

Merged
exceptionfactory merged 1 commit intoapache:mainfrom
dan-s1:NIFI-14312
Mar 4, 2025
Merged

Conversation

@dan-s1
Copy link
Contributor

@dan-s1 dan-s1 commented Mar 3, 2025

Summary

NIFI-14312

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using mvn clean install -P contrib-check
    • JDK 21

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

…icated code and introducing paramaterized tests.
Copy link
Contributor

@exceptionfactory exceptionfactory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvements @dan-s1, looks good! +1 merging

@exceptionfactory exceptionfactory merged commit cd25603 into apache:main Mar 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants