NIFI-14322: Creating processor to fetch Box file using a representation#9769
Closed
ncover21 wants to merge 3 commits intoapache:mainfrom
Closed
NIFI-14322: Creating processor to fetch Box file using a representation#9769ncover21 wants to merge 3 commits intoapache:mainfrom
ncover21 wants to merge 3 commits intoapache:mainfrom
Conversation
exceptionfactory
requested changes
Mar 5, 2025
Contributor
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for putting together this new Processor @ncover21! The overall approach looks good, I just noted a few recommendations. There also appears to be one Checkstyle violation that needs to be corrected.
...-box-processors/src/main/java/org/apache/nifi/processors/box/FetchBoxFileRepresentation.java
Outdated
Show resolved
Hide resolved
...-box-processors/src/main/java/org/apache/nifi/processors/box/FetchBoxFileRepresentation.java
Outdated
Show resolved
Hide resolved
...-box-processors/src/main/java/org/apache/nifi/processors/box/FetchBoxFileRepresentation.java
Outdated
Show resolved
Hide resolved
...-box-processors/src/main/java/org/apache/nifi/processors/box/FetchBoxFileRepresentation.java
Outdated
Show resolved
Hide resolved
...-box-processors/src/main/java/org/apache/nifi/processors/box/FetchBoxFileRepresentation.java
Outdated
Show resolved
Hide resolved
Contributor
Author
Thanks David for the review, comments have been addressed. |
10 tasks
pvillard31
approved these changes
Mar 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A processor responsible for fetching a specific Box File using a Representation.
https://developer.box.com/guides/representations/
NIFI-14322
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation