NIFI-14343 Replaced IdentifyMimeType property descriptors Config File and Config Body with one property descriptor using identifiesExternalResource. #9793
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dan-s1
force-pushed
the
NIFI-14343
branch
2 times, most recently
from
01ec6f9 to
19f40a4
Compare
bobpaulin
reviewed
Mar 18, 2025
...-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java
Outdated
Show resolved
Hide resolved
dan-s1
force-pushed
the
NIFI-14343
branch
2 times, most recently
from
8672c03 to
98f5d1f
Compare
Member
|
Can you update the AllowableValues for REPLACE and MERGE to include the words "custom MIME configurations" to make it more clear? |
dan-s1
force-pushed
the
NIFI-14343
branch
2 times, most recently
from
5262598 to
338b7e9
Compare
mosermw
reviewed
Mar 31, 2025
...-standard-processors/src/main/java/org/apache/nifi/processors/standard/IdentifyMimeType.java
Show resolved
Hide resolved
… and Config Body with one property descriptor using identifiesExternalResource.
…om MIME Configuration'.
… wording "custom MIME types configuration".
…or reuse in setup and customValidate methods.
Member
|
Thanks for the changes @dan-s1, this looks good now. I tested a bunch of scenarios and the migration worked in each. |
TomaszK-stack
pushed a commit
to TomaszK-stack/nifi
that referenced
this pull request
May 5, 2025
… and Config Body with one property descriptor using identifiesExternalResource. Signed-off-by: Mike Moser <mosermw@apache.org> Closes apache#9793
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14343
This PR removes the two property descriptors Config File and Config Body and replaces it with a single property descriptor which uses identifiesExternalResource which thereby allows a single property descriptor to support a configuration body, configuration file path or a configuration specified by a URL. In addition validation was added to ensure if a custom configuration is replacing the defaults or being merged with the defaults that it is indeed a valid configuration. This PR no longer supports expression language for this new property descriptor since if if a file path is specified in an attribute, it will be treated as a configuration body and not a file path.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation