NIFI-14365 Filter collaboration by actual json value in GetBoxFileCollaborators#9801
Closed
awelless wants to merge 1 commit intoapache:mainfrom
Closed
Conversation
awelless
commented
Mar 13, 2025
| flowFilesFirst.assertAttributeEquals("box.collaborations.accepted.viewer.users.ids", TEST_USER_ID_3); | ||
| flowFilesFirst.assertAttributeEquals("box.collaborations.accepted.viewer.users.logins", TEST_USER_EMAIL_3); | ||
| flowFilesFirst.assertAttributeEquals("box.collaborations.accepted.viewer uploader.groups.ids", TEST_GROUP_ID_1); | ||
| flowFilesFirst.assertAttributeEquals("box.collaborations.accepted.viewer uploader.groups.emails", TEST_GROUP_EMAIL_1); |
Contributor
Author
There was a problem hiding this comment.
I reckon that attribute names should be consistent with Box roles. Even when they contain hyphens or spaces.
awelless
force-pushed
the
NIFI-14365_Better_filter_in_GetBoxFileCollaborators
branch
from
f6b9a83 to
36c335f
Compare
awelless
changed the title
pvillard31
approved these changes
Mar 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-14365
Instead of lower case enum names, the processor should filter collaborations by their json values.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation