NIFI-14467 Gracefully stop ConsumeBoxEnterpriseEvents#9873
Conversation
|
Thanks @awelless, can you rebase this pull request? That will resolve unrelated unit test failures. |
| while (true) { | ||
| if (!isScheduled()) { |
There was a problem hiding this comment.
Instead of having the nested conditional, can the while condition be changed to while (isScheduled())?
There was a problem hiding this comment.
The reason for the condition is to provide a reason why we stopped further processing. Similar to when eventLog.getSize() == 0
There was a problem hiding this comment.
Thanks for the response. Given that these are debug logs, not written in the default configuration, I recommend simplifying the implementation and removing this log. The other debug logs that include the stream position are useful, and should provide sufficient details for debugging.
06b1431 to
07850d4
Compare
07850d4 to
af71361
Compare
exceptionfactory
left a comment
There was a problem hiding this comment.
Thanks for making the adjustments @awelless, the latest version looks good! +1 merging
…#9873) Signed-off-by: David Handermann <exceptionfactory@apache.org>
Summary
NIFI-14467
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000Pull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
mvn clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation